docs(devlog): 260815 old-draft closeout and release-readiness record #1759
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,54 @@ | ||
| # 030 - Release-readiness record (wp3) | ||
|
|
||
| ## Gates on dev (all on ssh lidge per owner directive) | ||
|
|
||
| - cc8e5a30 (pre-release-guard tip): INSTALL_OK, AUDIT_OK (bun run audit:high, | ||
| root+gui, 0 vulnerabilities), TSC_OK, PRIVACY_OK, LINT_GUI_OK, | ||
| GUI_TESTS_OK (855 pass / 0 fail, 147 files), root suite 12259 pass / | ||
| 11 skip / 0 fail (12270 tests, 781 files [457.69s]), docs-site build OK | ||
|
Comment on lines
+5
to
+8
Contributor
There was a problem hiding this comment. 🔒 Security & Privacy | 🟡 Minor | ⚡ Quick win Limit the audit claim to the checked severity.
🤖 Prompt for AI Agents |
||
| (323 pages). | ||
| - Final tip 14196b208 (includes #1753): TSC_OK, PRIVACY_OK, root suite | ||
| 12339 pass / 11 skip / 0 fail (12350 tests, 785 files [462.03s]). | ||
| First run showed the known 7-failure react-resolution artifact when the | ||
| gui install step is skipped; rerun with gui deps installed is clean. | ||
| - dev CI: Cross-platform CI green on cc8e5a30 (run 31872155114). | ||
|
Comment on lines
+10
to
+14
Contributor
There was a problem hiding this comment. 🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -eu
printf '%s\n' '--- target document ---'
sed -n '1,70p' devlog/_plan/260815_old_draft_triage/030_release_readiness.md
printf '%s\n' '--- release workflow around release-SHA checks ---'
sed -n '120,220p' .github/workflows/release.yml
printf '%s\n' '--- references to the documented SHAs and CI run ---'
rg -n -C 3 '14196b208|cc8e5a30|31872155114|Cross-platform CI|expected-sha|ci\.yml' \
devlog .github scripts 2>/dev/null || trueRepository: lidge-jun/opencodex Length of output: 50378 🏁 Script executed: #!/bin/bash
set -eu
printf '%s\n' '--- target document ---'
nl -ba devlog/_plan/260815_old_draft_triage/030_release_readiness.md | sed -n '1,65p'
printf '%s\n' '--- release workflow lines 135-215 ---'
nl -ba .github/workflows/release.yml | sed -n '135,215p'
printf '%s\n' '--- exact references in target document ---'
rg -n -C 2 '14196b208|cc8e5a30|31872155114|Cross-platform CI|final tip|pending' \
devlog/_plan/260815_old_draft_triage/030_release_readiness.mdRepository: lidge-jun/opencodex Length of output: 1112 🏁 Script executed: #!/bin/bash
set -eu
printf '%s\n' '--- target document ---'
cat -n devlog/_plan/260815_old_draft_triage/030_release_readiness.md | sed -n '1,65p'
printf '%s\n' '--- release workflow lines 135-215 ---'
sed -n '135,215p' .github/workflows/release.ymlRepository: lidge-jun/opencodex Length of output: 6973 🏁 Script executed: #!/bin/bash
set -eu
repo='lidge-jun/opencodex'
short_sha='14196b208'
if command -v gh >/dev/null 2>&1; then
full_sha="$(gh api "repos/${repo}/commits/${short_sha}" --jq '.sha')"
printf 'resolved_sha=%s\n' "$full_sha"
gh api "repos/${repo}/actions/runs?head_sha=${full_sha}&per_page=100" \
--jq '.workflow_runs[] | [.id,.name,.event,.status,.conclusion,.head_branch,.head_sha,.html_url] | `@tsv`'
else
full_sha="$(curl -fsSL "https://api.github.com/repos/${repo}/commits/${short_sha}" | sed -n 's/.*"sha": "\([0-9a-f]\{40\}\)".*/\1/p' | head -n 1)"
printf 'resolved_sha=%s\n' "$full_sha"
curl -fsSL "https://api.github.com/repos/${repo}/actions/runs?head_sha=${full_sha}&per_page=100" |
python3 -c '
import json, sys
for r in json.load(sys.stdin)["workflow_runs"]:
print("\t".join(str(r.get(k, "")) for k in
["id","name","event","status","conclusion","head_branch","head_sha","html_url"]))
'
fiRepository: lidge-jun/opencodex Length of output: 375 Record the final tip’s cancelled CI run.
🤖 Prompt for AI Agents |
||
|
|
||
| ## Anomaly found and hardened | ||
|
|
||
| - Version line: dev package.json was 2.18.0 while npm latest = 2.19.0 | ||
| (main). Neither v2.18.2 nor v2.19.0 is an ancestor of dev; the release | ||
| helper only checked the proposed version was unused, so an obsolete | ||
| target could have moved a dist-tag backwards. | ||
| - Fix landed: #1753 (fix/260815-release-version-guard, a147da455) adds a | ||
| channel-forward guard to scripts/release.ts (npm dist-tags read, | ||
| semver-ordered strictly-newer requirement, preview channel compares | ||
| against preview) with 3 new shimmed tests. | ||
|
|
||
| ## Remaining release-time requirements (owner actions at promotion) | ||
|
|
||
| 1. Pick the next version strictly newer than npm latest (2.19.0) - the | ||
| guard now enforces this mechanically. | ||
|
Comment on lines
+22
to
+30
Contributor
There was a problem hiding this comment. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Scope the version baseline by release channel. Lines 22-25 state that preview compares against the 🤖 Prompt for AI Agents |
||
| 2. Promotion dev -> main is maintainer-controlled (MAINTAINERS.md); the | ||
| helper must run on main/preview with clean tree; CI must be green on | ||
| the release-bump SHA before the workflow dispatch (expected-sha pinned). | ||
| 3. Artifact closure at release time: workflow dry-run/pack, OIDC publish, | ||
| registry visibility, tag + GitHub Release on the release SHA. | ||
| 4. Release notes are generated from PR labels after npm publish - audit | ||
| labels of the landed batch PRs (#1736 #1744 #1749 #1753) if curated | ||
| notes matter. | ||
|
|
||
| ## Dispositions recap (18 old drafts) | ||
|
|
||
| - Landed via #1744 (6): #1664 #1669 #1660 #1652 #1165 #1644 (cherry-picked, | ||
| authorship preserved, repaired, review-verified). | ||
| - Rebuilt + verified, HELD for owner landing decision (4): #1521 #1584 | ||
| #1569 #1655 - int/260815-heavy @ 2799fba20, lidge suite 12330 pass / | ||
| 0 fail, reviewer PASS x4. One-command land on approval. | ||
|
Comment on lines
+44
to
+46
There was a problem hiding this comment.
The reviewed commit's parent already contains merge commit AGENTS.md reference: AGENTS.md:L75-L78 Useful? React with 👍 / 👎. |
||
| - KEEP-DRAFT with maintainer comments (8): #1498 #1367 #1552 #1557 #1526 | ||
| #1624 #1645 #1703. | ||
|
|
||
| ## Follow-up fixed in flight | ||
|
|
||
| - #1749: GUI gate tests broke after #1744 (mcode inventory assertions + | ||
| zh-TW allowlist) - fixed same-day, dev CI green again. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The unit's
000_plan.mdexplicitly mapswp5to030for the release-readiness loop, whilewp3is the light-six integration phase recorded in020. Changing this heading fromwp5towp3makes the execution record contradict its work-phase map; retainwp5here or update the plan and all corresponding phase references consistently.Useful? React with 👍 / 👎.