-
Notifications
You must be signed in to change notification settings - Fork 732
fix: isolate Compatibility Lab from core runtime #1676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| import { readConfigDiagnostics } from "../config"; | ||
| import type { OcxConfig } from "../types"; | ||
| import { setLabAutomationShutdownHook } from "./lifecycle"; | ||
|
|
||
| type RuntimeOwner = { | ||
| release: () => void; | ||
| }; | ||
|
|
||
| const runtimeOwners = new Map<string, RuntimeOwner>(); | ||
|
|
||
| function configKey(configDir?: string): string { | ||
| return configDir ?? ""; | ||
| } | ||
|
|
||
| function loadLatestConfig(fallback: OcxConfig): OcxConfig { | ||
| try { | ||
| return readConfigDiagnostics().config; | ||
| } catch { | ||
| return fallback; | ||
| } | ||
| } | ||
|
|
||
| function installShutdownHook(): void { | ||
| setLabAutomationShutdownHook(() => { | ||
| const { | ||
| requestLabAutomationShutdown, | ||
| stopLabAutomationScheduler, | ||
| } = require("../lab/automation/orchestrator") as typeof import("../lab/automation/orchestrator"); | ||
| requestLabAutomationShutdown(); | ||
| for (const [key, owner] of runtimeOwners) { | ||
| stopLabAutomationScheduler(key || undefined); | ||
| owner.release(); | ||
| } | ||
| runtimeOwners.clear(); | ||
| }); | ||
| } | ||
|
|
||
| /** | ||
| * Lazily install the host-owned dispatch authority required by explicit Lab | ||
| * automation requests. Importing this module alone does not load Lab runtime | ||
| * code; the Lab graph is entered only when an explicit caller invokes this. | ||
| */ | ||
| export function ensureLabAutomationRuntime(config: OcxConfig, configDir?: string): void { | ||
| const key = configKey(configDir); | ||
| if (runtimeOwners.has(key)) return; | ||
|
|
||
| const { setLabAutomationDispatchDeps } = require( | ||
| "../lab/automation/orchestrator", | ||
| ) as typeof import("../lab/automation/orchestrator"); | ||
| const { createProductionLabRouteExecutor } = require( | ||
| "../lib/lab-live-route-production", | ||
| ) as typeof import("../lib/lab-live-route-production"); | ||
| const loadConfig = () => loadLatestConfig(config); | ||
| const release = setLabAutomationDispatchDeps({ | ||
| configDir, | ||
| loadConfig, | ||
| routeExecutor: createProductionLabRouteExecutor({ configDir, loadConfig }), | ||
| }); | ||
| runtimeOwners.set(key, { release }); | ||
| installShutdownHook(); | ||
| } | ||
|
|
||
| /** Test-only reset for direct management-route tests that do not own a server lifecycle. */ | ||
| export function resetLabAutomationRuntimeForTests(): void { | ||
| for (const owner of runtimeOwners.values()) owner.release(); | ||
| runtimeOwners.clear(); | ||
| setLabAutomationShutdownHook(null); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.