fix(antigravity): persist replay expiry - #1613
Conversation
|
✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe replay expiry sweep now marks the durable snapshot dirty when it deletes sessions. A durability test verifies that flushing the snapshot removes expired sessions and their stored signatures. ChangesReplay expiry persistence
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: 🟡 Moderate · up to The replay expiry fix is localized and its targeted validation passes, but the PR is still marked draft with required readiness checks incomplete, including a non-green full-suite result. Merge should wait for those checks to be completed or explicitly accepted by the owner. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏳ DRAFT
What to do
Review readiness checklist
2/4 boxes ticked. This PR stays in draft until every box above is ticked. |
|
@coderabbitai review |
✅ Action performedReview finished.
|
eb9fa39 to
a2878cd
Compare
|
@coderabbitai review |
|
a2878cd to
067c4a7
Compare
067c4a7 to
ec2f7e1
Compare
Summary
The replay cache already expired entries in memory, but expiry did not advance the snapshot mutation generation. During an idle period, the protected
antigravity-replay.jsonfile could therefore retain an opaque thought signature after its one-hour in-memory lifetime until some unrelated replay mutation or a later load rewrote the file.Verification
bun test --isolate tests/google-antigravity-replay.test.ts tests/state-store-sweeper.test.ts(72 pass)bun run typecheckbun run privacy:scanbun test --isolate tests/model-rename-migration.test.ts(9 pass)bun test --isolate tests/state-store-sweeper.test.ts tests/shutdown-drain.test.ts tests/server-background-lifecycle.test.ts tests/storage-mutation-race.test.ts(43 pass)devatb583d64970e087bb85fa04b7356889070e06a0b5; the replay/sweeper plus latest usage/settings focused set passes on Bun 1.3.14 and Bun 1.4.0-canary.1 (120 pass each), with typecheck passing on both runtimes.Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
Summary by CodeRabbit
Bug Fixes
Tests