fix(xai): expose Grok 4.6 xhigh reasoning - #1593
Conversation
|
✅ Deterministic PR hygiene checks passed. |
✅ READY
Review readiness checklist
✅ 4/4 boxes ticked. This pull request is already Ready for Review. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThe xAI registry now advertises ChangesGrok 4.6 reasoning and catalog support
Estimated code review effort: 2 (Simple) | ~15 minutes Mergeability Score: ⚪ Minimal · up to This localized change exposes the documented Grok 4.6 reasoning ladder while preserving existing configuration behavior and updating related documentation and tests; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The Grok 4.6 seed still used the 4.5 low/medium/high ladder, so Codex xhigh requests never left the proxy. Keep 4.5 unchanged and send the documented xhigh rung on 4.6. Closes lidge-jun#1592
683f5f6 to
dcb3b6b
Compare
dcb3b6b to
f813db1
Compare
|
Tip For best results, initiate chat on the files or code changes.
🧠 Learnings usedYou are interacting with an AI system. |
|
Tip For best results, initiate chat on the files or code changes.
🧠 Learnings usedYou are interacting with an AI system. |
|
Tip For best results, initiate chat on the files or code changes.
🧠 Learnings usedYou are interacting with an AI system. |
Summary
low/medium/high/xhighladder forgrok-4.6; keepgrok-4.5onlow/medium/high.highdefault in the generated Codex catalog.max/ultrato Grok 4.6xhigh; no provider alias map is needed.highdefault while preserving an explicit user default.xhighinto user-owned configuration.low/medium/highuntil Cursor live discovery exposes anxhighwire ID.Official contract: https://docs.x.ai/developers/model-capabilities/text/reasoning
Fixes #1592
Review follow-up
The follow-up review correctly identified that the earlier
{ max: "xhigh" }registry map abused stale-ladder healing and could override an operator's intentional narrower ladder or provider-wide downgrade map. That map has been removed and regression coverage now pins the override behavior.The reported routing/catalog/CLI inconsistencies depended on that removed healing behavior. With no synthetic model map, an explicit three-level API-key ladder remains three-level consistently across those surfaces. The OAuth preset path is refreshed by its existing authoritative reconciliation.
The OAuth subscription proxy does not publish a separate reasoning-effort contract. This PR follows xAI's public Grok 4.6 contract but does not add speculative 400 retry/downgrade behavior without a reproducible proxy rejection.
Verification
bun test tests/reasoning-effort.test.ts tests/provider-registry-parity.test.ts tests/effort-policy.test.ts tests/catalog-vision-sidecar-modalities.test.ts tests/xai-transport.test.ts tests/oauth-provider-reconcile.test.ts tests/routing-profile.test.ts tests/policy-execution.test.ts tests/route-explainability.test.ts— 217 passed, 0 failedbun run test— exercised the full 716-file suite in 556.58s: 11,483 passed and 8 skipped; the sole failure was the unrelated timing-sensitive CL-07 inactivity test under full-suite load.bun test --isolate tests/lab-fabric-task.test.ts -t 'inactivity timeout is bounded for trusted route executors'— passed in 3 consecutive retries (773.66ms, 763.03ms, 768.19ms).bun run typecheck— passedbun run privacy:scan— passedgit diff --check upstream/dev...HEAD— passedupstream/devbefore the final focused run.Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.
Summary by CodeRabbit
New Features
lowthroughxhigh, withhighas the default.maxandultrawhere applicable.Documentation
Bug Fixes