chore(release): avoid persisted checkout credentials - #1568
Conversation
Replaced git tag and push commands with GitHub CLI API call to create a tag.
|
✅ Deterministic PR hygiene checks passed. |
|
Warning Review limit reached
Next review available in: 12 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Ingwannu
left a comment
There was a problem hiding this comment.
Approved on exact head 1965dddf76c2f6ca50f46fe8c9101922ec17a721. persist-credentials: false removes the checkout token from Git configuration, and tag creation now uses the explicitly scoped GH_TOKEN through the GitHub refs API only after release notes are rendered. The change preserves the existing exact-SHA and pre-existing-tag checks, targets dev, is mergeable, and exact-head CI is green.
|
This remains approved and merge-ready at exact head I attempted the merge again, but GitHub rejects this maintainer token because the PR modifies |
|
Reviewed during today's landing round and deliberately not merged — this needs a maintainer security review, not a routine merge. The change looks correct on its face: But Leaving it open and unmerged for a maintainer to review against |
Summary
GITHUB_TOKENout of the checkout's Git authentication configurationWhy
actions/checkoutpersists its authentication credentials by default.The Release workflow has
contents: write, so keeping those credentials in the checkout means later workflow steps can implicitly authenticate Git operations such asgit pushwithout explicitly requesting or configuring credentials.The current Release workflow does not rely on that behavior:
GH_TOKENSetting
persist-credentials: falsetherefore removes an unnecessary ambient write credential while preserving the existing release flow.Impact
Normal release behavior is unchanged.
A future workflow step that intentionally needs an authenticated Git write will need to configure authentication explicitly rather than inheriting checkout credentials.
Review
Ready for review.
@lidge-jun @Ingwannu
Summary by CodeRabbit