Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,60 @@ void shouldParseMentionChatCommandIssueCommentEvent() {
assertThat(payload.getMentionedBot()).isTrue();
}

@Test
void shouldParseRepresentativeCommentTypesWithDeterministicRouting() {
GitHubPullRequestWebhookPayload legacyReviewPayload = parserWithoutClassifierButLlmAvailable()
.parse("issue_comment", issueCommentPayload("created", "/review", true));
assertThat(legacyReviewPayload.isIgnored()).isFalse();
assertThat(legacyReviewPayload.getCommandType()).isEqualTo(GithubCommandType.REVIEW.name());
assertThat(legacyReviewPayload.getMentionedBot()).isFalse();

GitHubPullRequestWebhookPayload explicitReviewPayload = parserWithoutClassifierButLlmAvailable()
.parse("issue_comment", issueCommentPayload("created", "@x-pilotx review this PR", true));
assertThat(explicitReviewPayload.isIgnored()).isFalse();
assertThat(explicitReviewPayload.getCommandType()).isEqualTo(GithubCommandType.REVIEW.name());
assertThat(explicitReviewPayload.getMentionedBot()).isTrue();

GitHubPullRequestWebhookPayload summaryPayload = parserWithoutClassifierButLlmAvailable()
.parse("issue_comment", issueCommentPayload("created", "@x-pilotx summarize the current review findings", true));
assertThat(summaryPayload.isIgnored()).isFalse();
assertThat(summaryPayload.getCommandType()).isEqualTo(GithubCommandType.CHAT.name());
assertThat(summaryPayload.getMentionedBot()).isTrue();
}

@Test
void shouldParseRepresentativeCommentTypesThroughClassifierWhenNeeded() {
GitHubWebhookPayloadParser fixParser = parserWithAiResponse("""
{
"type": "FIX",
"dryRun": false,
"reason": "asks the bot to fix the above issues"
}
""");
GitHubPullRequestWebhookPayload fixPayload = fixParser.parse(
"issue_comment",
issueCommentPayload("created", "@x-pilotx please fix the above issues", true)
);
assertThat(fixPayload.isIgnored()).isFalse();
assertThat(fixPayload.getCommandType()).isEqualTo(GithubCommandType.FIX.name());
assertThat(fixPayload.getMentionedBot()).isTrue();

GitHubWebhookPayloadParser chatParser = parserWithAiResponse("""
{
"type": "CHAT",
"dryRun": false,
"reason": "greeting"
}
""");
GitHubPullRequestWebhookPayload chatPayload = chatParser.parse(
"issue_comment",
issueCommentPayload("created", "@x-pilotx hi", true)
);
assertThat(chatPayload.isIgnored()).isFalse();
assertThat(chatPayload.getCommandType()).isEqualTo(GithubCommandType.CHAT.name());
assertThat(chatPayload.getMentionedBot()).isTrue();
}

@Test
void shouldParseUnknownMentionAsCommand() {
GitHubWebhookPayloadParser aiParser = parserWithAiResponse("""
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
package com.codepilot.module.review.validation;

import org.junit.jupiter.api.Test;

import static org.assertj.core.api.Assertions.assertThat;

class ReviewBotValidationFixtureTest {

@Test
void shouldKeepAnObviousSqlRiskSnippetForReviewBotValidation() {
String unsafeSql = "SELECT * FROM users WHERE id = ${id}";

assertThat(unsafeSql).contains("${id}");
}
}
Loading