Libretro: support Vulkan swapchains with more than eight images#455
Open
mattakins wants to merge 1 commit into
Open
Libretro: support Vulkan swapchains with more than eight images#455mattakins wants to merge 1 commit into
mattakins wants to merge 1 commit into
Conversation
mattakins
marked this pull request as ready for review
July 19, 2026 18:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The libretro Vulkan shim stores its fake swapchain images in a fixed eight-element array.
RetroArch now supports swapchains with up to 16 images (libretro/RetroArch#19186), which exposed this core-side limit on drivers that return more than eight images.
When that happens, Dolphin writes past the fixed array while creating the fake swapchain. In release builds, this corrupts adjacent state, including synchronization objects, and hangs on booting a game.
Fix
Replace the fixed image array with dynamically sized storage based on the frame-slot mask reported by the frontend. This preserves the existing fake-swapchain behavior while removing the unsupported eight-image limit.
Validation