[Wayland]Add support for tearing-control-v1 protocol - #19235
Merged
Conversation
Contributor
|
Can you incorporate this in your |
The tearing-control-v1 support added the manager destroy call between idle_inhibit_manager's if and its else, so the DBus screensaver-inhibit fallback teardown (dbus_screensaver_uninhibit / dbus_close_connection) became gated on wp_tearing_control_manager_v1 being absent instead of zwp_idle_inhibit_manager_v1. Consequences: - Compositor with idle-inhibit but no tearing-control: DBus uninhibit and close_connection fire spuriously even though the DBus fallback was never used. - Compositor with tearing-control but no idle-inhibit (DBus fallback in use): the else is skipped, leaking the DBus connection and leaving the screensaver inhibited after exit. Move the tearing_control_manager destroy out from between the if/else so the DBus fallback binds to idle_inhibit_manager again.
Contributor
Author
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guidelines
C89_BUILD=1Description
This protocol sends hint to the compositor to allow async page flips via DRM_MODE_PAGE_FLIP_ASYNC. It's tied to Vsync state so when Vsync is off - RetroArch will send async hint and compositor will guarantee that tearing is allowed and non blocked. The protocol allows tearing both for fullscreen and non-fullscreen surfaces, but I don't know if is any of compositors allowing tearing for non-fullscreen surfaces. Tested in KDE Plasma 6.3.5.
Supersedes #19209
Related Issues
[Any issues this pull request may be addressing]
Related Pull Requests
[Any other PRs from related repositories that might be needed for this pull request to work]
Reviewers
[If possible @mention all the people that should review your pull request]