autodetect: enhance Bliss-Box pad type detection and updated pad types.#19231
Open
Rendman wants to merge 2 commits into
Open
autodetect: enhance Bliss-Box pad type detection and updated pad types.#19231Rendman wants to merge 2 commits into
Rendman wants to merge 2 commits into
Conversation
logging: fixed an issue with null values creating spurious file system garbage.
Author
|
Additionally the hidraw path will require a udev rule to set the correct permissions. |
Collaborator
|
This sounds like a great improvement. Thanks for taking it on! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves Bliss-Box autodetection and hardens Linux logging initialization.
Adds a Linux HIDRAW-based Bliss-Box probe path for pad type resolution before falling back to libusb. This prevents issues with libusb and kernel driver fighting. This also maintains the libusb code for platforms that need it, but make the Bliss Box devices much more usable on modern Linux based systems.
Updates Bliss-Box pad-type ID mapping in tasks/task_autodetect_blissbox.c to align with the documented Bliss-Box type IDs. (From the official test application source)
Adds a small C89 safety fix in verbosity.c by zero-initializing log_directory in rarch_log_file_init to avoid stack garbage being used when --log-file is a bare filename.
Related Issues
Fixes: #17415
Potentially fixes: #8476 (update... it does not)
Related Pull Requests
None Known.
Reviewers