allow quotes in conf values#19218
Open
Jamiras wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Any string written to
retroarch.cfgcontaining double quotes will now explicitly escape the double quote. Other characters are not escaped to prevent breaking of things like paths. When reading the config file, a\"pair will be converted to". Any other backslashes will be treated as single characters.Before:
Would be loaded as
it's a.Now, it will be written as:
Which will retrieve the full
it's a "secret"..Other instances of backslashes are not escaped.
Related Issues
Fixes #15848
Related Pull Requests
n/a
Reviewers
[If possible @mention all the people that should review your pull request]