webOS: fix file browser hang when opening filesystem root#19203
Open
gprot42 wants to merge 2 commits into
Open
webOS: fix file browser hang when opening filesystem root#19203gprot42 wants to merge 2 commits into
gprot42 wants to merge 2 commits into
Conversation
Under jailer, readdir/stat on / can stall the UI via /proc and /sys. Do not offer "/" as a drive, redirect root back to the safe drive list, and skip virtual FS nodes if root is enumerated.
4 tasks
Fixes CI webOS compile failure: implicit declaration of string_is_equal when skipping virtual FS nodes under jail root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On webOS, RetroArch runs under jailer. Opening Load Content and selecting filesystem root (
/), or navigating Parent Directory up to/, can freeze the UI. Under the jail, directory enumeration touches virtual filesystems such as/procand/sys, which stalls the main thread.This change keeps the file browser on safe storage locations and refuses to treat
/as a normal browsable directory on webOS.Changes
frontend/drivers/platform_unix.c— Safe webOS drive list (app package, media, USB, temp); do not offer/menu/menu_displaylist.c— If path is/, re-show drive list instead ofreaddiron jail rootlibretro-common/lists/dir_list.c— Skipproc/sys/dev/runwhen listing/Test plan
/does not freeze; safe drives shown/media/internal,/media/developer, app directoryNotes
Companion PR for Load Content visibility (empty file list / wrong start dir) stacks on this branch.
Previously opened against the wrong fork (webosbrew#14); reopening here per maintainer guidance.