Skip to content

Pin surge-ping to 0.8: 0.9.1 needs 64-bit atomics #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BKPepe merged 2 commits into from
Nov 5, 2026
Merged

Pin surge-ping to 0.8: 0.9.1 needs 64-bit atomics #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a3e40e
deps: surge-ping 0.9.1 does not build on 32-bit targets
BKPepe Nov 5, 2026
21acce8
ci: cross-build a target without 64-bit atomics
BKPepe Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,11 @@ jobs:
cross:
name: ${{ matrix.target }} (${{ matrix.tls }})
runs-on: ubuntu-latest
env:
# 32-bit PowerPC has no 64-bit atomic instruction, so the compiler calls
# into libatomic. Without this the link succeeds and CI stays green, but
# the loader cannot start the binary.
RUSTFLAGS: ${{ matrix.target == 'powerpc-unknown-linux-gnu' && '-C link-arg=-latomic' || '' }}
strategy:
fail-fast: false
matrix:
Expand All @@ -170,6 +175,11 @@ jobs:
# none for the target; OpenWrt builds link the SDK's libopenssl.
- target: aarch64-unknown-linux-musl
tls: native-tls
# A target whose `max-atomic-width` is 32, the shape of OpenWrt's
# mpc85xx, ath79 and ramips. A dependency that reaches for
# `AtomicU64` builds on every target above and fails only here.
- target: powerpc-unknown-linux-gnu
tls: native-tls
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
Expand Down
100 changes: 79 additions & 21 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ serde = { version = "1", features = ["derive"] }
tokio-native-tls = { version = "0.3", optional = true }
serde_json = { version = "1", features = ["raw_value"] }
socket2 = { version = "0.5", features = ["all"] }
surge-ping = "0.9"
surge-ping = "0.8"
tokio = { version = "1", features = ["rt-multi-thread", "macros", "net", "time", "io-util", "sync", "fs", "signal"] }
tower-service = "0.3"
url = "2"
Expand Down
Loading