fix(relay): remove external addr if there is no replacement reservation#6285
Open
dariusc93 wants to merge 3 commits intolibp2p:masterfrom
Open
fix(relay): remove external addr if there is no replacement reservation#6285dariusc93 wants to merge 3 commits intolibp2p:masterfrom
dariusc93 wants to merge 3 commits intolibp2p:masterfrom
Conversation
dariusc93
changed the title
dariusc93
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the local node has an active reservation with a relay, it notifies swarm of the new external address. When calling
Swarm::remove_listeneron a listener with an active relay reservation, the address would still persist as an external address despite the local node not considered listening on the relay. This PR changes it so the when the node stops listening on the relay, it removes the external address if there is no other reservation to replace it.resolves #6165.
Notes & open questions
Change checklist