Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions libp2p/peer/peerstore.py
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,14 @@ def consume_peer_record(self, envelope: Envelope, ttl: int) -> bool:
record = envelope.record()
peer_id = record.peer_id

# Reject records whose signer does not match the record's peer ID.
try:
signer_peer_id = ID.from_pubkey(envelope.public_key)
except Exception:
return False
if signer_peer_id != peer_id:
return False

existing = self.peer_record_map.get(peer_id)
if existing and existing.seq > record.seq:
return False # reject older record
Expand Down
1 change: 1 addition & 0 deletions newsfragments/1338.bugfix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed KadDHT peer record validation to ensure signed ``PeerRecord``s have matching signer identity and peer ID, preventing certified address book poisoning for arbitrary peer IDs.
Loading