fix: use getRandomValues from WebCrypto#3540
Merged
Merged
Conversation
The `randomBytes` function exported from `@libp2p/crypto` was necessary when the WebCrypto function getRandomValues was not widely implemented. Now is is so switch to that and deprecate `randomBytes` for future removal. This Prevents accidentally pulling in the `@libp2p/crypto` dependency which can have knock on effects for bundles due to transient dependencies.
tabcat
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
randomBytesfunction exported from@libp2p/cryptowas necessary when the WebCrypto functiongetRandomValueswas not widely implemented.Now it is so switch to that and deprecate
randomBytesfor future removal.This removes a dependency on
@libp2p/cryptoin a few places which can have knock on effects for bundles due to duplicated transient deps of different versions, extra@noble/*deps, etc.Change checklist