Allow passing options to Go symbolizer constructor #1406
Merged
+239
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1406 +/- ##
==========================================
- Coverage 95.84% 95.72% -0.12%
==========================================
Files 61 61
Lines 11076 11076
==========================================
- Hits 10616 10603 -13
- Misses 460 473 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bobrik
force-pushed
the
ivan/configurable-go-symbolizer
branch
2 times, most recently
from
0078db9 to
6992731
Compare
d-e-s-o
reviewed
Jan 5, 2026
Collaborator
d-e-s-o
left a comment
d-e-s-o
left a comment
There was a problem hiding this comment.
Thanks, yes, that will be useful! Left a few comments.
|
|
||
| type SymbolizerOption func(*SymbolizerOptions) | ||
|
|
||
| func WithDebugDirs(dirs []string) SymbolizerOption { |
Collaborator
There was a problem hiding this comment.
So if we now start using the functional options pattern then should we use it for the various input sources as well?
Contributor
Author
There was a problem hiding this comment.
I'll make a separate PR for this.
Signed-off-by: Ivan Babrou <github@ivan.computer>
bobrik
force-pushed
the
ivan/configurable-go-symbolizer
branch
from
6992731 to
409a7f5
Compare
d-e-s-o
approved these changes
Jan 6, 2026
Collaborator
d-e-s-o
left a comment
d-e-s-o
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.