Skip to content

Conversation

@ChengHauYang
Copy link
Member

@ChengHauYang ChengHauYang commented Jan 20, 2026

It appears that https://civet.inl.gov/repo/8/ does not recognize PR #4263, so as @roystgnr suggested, we will close #4263 and open this new PR.

Currently, project_vector and project_solution in libMesh apply the projection operation to all elements and all variables. It would be beneficial to extend these APIs to allow projection onto specific element ranges and selected variables only. This capability is implemented in the new PR.

@roystgnr
Copy link
Member

That Test complex and infinite failure might be as simple to fix as changing Real to Number where appropriate in project_solution_test.C

@ChengHauYang
Copy link
Member Author

Thanks, @roystgnr. I have fixed that bug.

@moosebuild
Copy link

moosebuild commented Jan 21, 2026

Job Coverage, step Generate coverage on 75159ac wanted to post the following:

Coverage

b252b8 #4368 75159a
Total Total +/- New
Rate 65.31% 65.31% -0.00% 89.29%
Hits 77568 77587 +19 50
Misses 41196 41209 +13 6

Diff coverage report

Full coverage report

Warnings

  • New new line coverage rate 89.29% is less than the suggested 90.0%

This comment will be updated on new commits.

@roystgnr
Copy link
Member

You also managed to downgrade TIMPI in the same commit. 😆 git commit -a is a dangerous friend.

@ChengHauYang
Copy link
Member Author

ChengHauYang commented Jan 21, 2026

Sorry for the mistakes, @roystgnr. 😆 Thanks for catching! I’ve fixed the unintended TIMPI change.

Copy link
Member

@roystgnr roystgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to slip anything that's this central into the current already-trouble-plagued MOOSE update PR, which might end up depending on #4369 or something like it, but IMHO this is ready to merge after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants