Skip to content

T1=3 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liatb-rh wants to merge 3 commits into
base: main
Choose a base branch
from
Open

T1=3 #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccf3b4c
test3
liatb-rh Dec 29, 2024
e964276
Merge branch 't1' of https://github.com/liatb-rh/temp into t1
liatb-rh Dec 29, 2024
8f96c99
Update UseComputedHeightFromPageHeader.ts
liatb-rh Dec 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/demo/src/components/ConfirmationModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export const ConfirmationModal: React.FC<
const dmy = ()=>{
alert('ffff');
}
const dd =

@coderabbitai coderabbitai Bot Dec 29, 2024 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Incomplete variable assignment dd.
Currently, dd is declared without an assigned value. Remove it if not used or complete the assignment if needed.

-  const dd =
+  // Remove or initialize `dd`:
+  // const dd = someValue;

Committable suggestion skipped: line range outside the PR's diff.

@liatb-rh liatb-rh Dec 29, 2024

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix?

@coderabbitai coderabbitai Bot Dec 29, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liatb-rh Here's one straightforward way to fix the incomplete variable assignment by removing dd (if it isn't needed). For instance:

const dmy = () => {
  alert('ffff');
};

// Remove or replace dd if you don't need it.
// const dd = someValue; // If you do need it, initialize it properly.

return (
  <Modal /* ... */>
    {/* ... */}
  </Modal>
);


return (
<Modal
Expand Down
7 changes: 6 additions & 1 deletion apps/demo/src/migration-wizard/hooks/UseComputedHeightFromPageHeader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { useState, useEffect } from "react";
import { useWindowSize } from "react-use";

const DEFAULT_HEIGHT = 635;
let DEFAULT_HEIGHT = 635;

function getMainPageSectionVerticalPadding(pageMainSection: Element): number {
const { paddingTop, paddingBottom } = getComputedStyle(pageMainSection);
Expand All @@ -25,6 +25,11 @@ export function useComputedHeightFromPageHeader(): number {
getMainPageSectionVerticalPadding(pageMainSection);
const { height: basePageHeaderHeight, unknown } =
basePageHeader.getBoundingClientRect();





setHeight(
windowInnerHeight -
basePageHeaderHeight -
Expand Down
9 changes: 9 additions & 0 deletions apps/demo/src/ocm/VMwareMigrationCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@ export const VMwareMigrationCard: React.FC = () => {
</CardBody>
<CardBody>
<TextContent>





<Text>
Start your migration journey to OpenShift Virtualization. We will
create a migration assessment report and help you create a migration
Expand All @@ -52,6 +57,10 @@ export const VMwareMigrationCard: React.FC = () => {
<Flex>
<FlexItem>
<Link to="/migrate/wizard">




<Button variant="secondary">Start your migration journey</Button>
</Link>
</FlexItem>
Expand Down