-
Notifications
You must be signed in to change notification settings - Fork 7
Wip/edsl maxstore stdlib #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
8a5a5fb
Add requireNonZero helper and setNonZero example
Th0rgal 461c1bc
Align direct EVM asm with solc labels
Th0rgal b2719ee
Update status date
Th0rgal 768fadf
Add compareAndSwap helper + example
Th0rgal de05f3f
Add requireGt helper and setIfGreater example
Th0rgal c3bf8bf
Add sstoreAdd helper and bumpSlot example
Th0rgal 7dbdf0d
Add revertIf helper and setIfLess example
Th0rgal 1fbe6fe
Add requireLt and setIfBetween example
Th0rgal 083fa13
Add letSload helper and initOnce example
Th0rgal 30c2a2c
Add requireAnd helper and setIfNonZeroAndLess example
Th0rgal 9c078a7
Add sstoreInc helper and bumpIfNonZero example
Th0rgal d1730da
Add sstoreMax helper and updateMax example
Th0rgal 09ea02d
Add sstoreMin helper and updateMin example
Th0rgal 61e2376
Add requireBetween helper and addIfBetween example
Th0rgal d77d6fe
Add sstoreSub helper and subIfEnough example
Th0rgal 1670842
Add requireGte helper and setIfAtLeast example
Th0rgal 748b0da
Add requireZero helper and initToOne example
Th0rgal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compiler entries diverge from proved example definitions
Medium Severity
exampleEntry11(setIfBetween) andexampleEntry17(addIfBetween) use nestedStmt.if_(e.g.,if_ (gt v min) (if_ (lt v max) body revert) revert), while the corresponding proved definitionssetIfBetweenFunandaddIfBetweenFunuserequireBetween, which expands toif_ (Expr.and (gt v min) (lt v max)) body revert. These are structurally different ASTs that produce different Yul output viacompileStmt, so the Lean proofs verify a function body that differs from what the compiler actually compiles. Other entries likesetIfNonZeroAndLesskeep their compiler entry and example structurally aligned.Additional Locations (1)
research/lean_only_proto/DumbContracts/Compiler.lean#L271-L287