Support ABI hashing for static dynamic arrays#1863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note
Medium Risk
Adds a new hashing/codegen module that manipulates calldata and free memory, so incorrect layout/length calculations could silently change contract hashes. Scope is contained and covered by new compilation/Yul layout assertions and validation error tests.
Overview
Adds
Compiler.Modules.Hashing.abiEncodeStaticArrayModule(andabiEncodeStaticArray) to computekeccak256(abi.encode(array))for dynamic-array parameters with static-sized elements, using{param}_length/{param}_data_offset, copying the contiguous payload into free memory, and hashing the ABI head+length+data.Extends
CompilationModelFeatureTestwith a smoke spec that asserts key Yul layout properties, plus negative specs for bad ECM arity and zero-width elements; also asserts the trust report includes the new ABI-layout and keccak assumptions. Removes an accidentally duplicatedexternalsblock from an unrelated ADT alias payload test spec.Reviewed by Cursor Bugbot for commit 38e2d0d. Bugbot is set up for automated code reviews on this repo. Configure here.