Pin Unlink case to dynamic event source support#59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Notes
The Unlink case still carries dynamic_array_event_payloads as unsupported because the executable
emitsurface remains homogeneous (List Uint256) and cannot yet typecheck source-level mixed scalar/array event arguments.Note
Low Risk
Low risk: this only updates the pinned
veritydependency and corresponding case metadata/notes, with no changes to benchmark/proof logic itself.Overview
Pins the benchmark’s
veritydependency to commit3b7e69b(vialakefile.leanandlake-manifest.json) to pick up newer translation support.Updates the
UnlinkXyzpool case metadata to match the new Verity pin and records the relevant upstream Verity PRs (#1870 memory-array helper lowering and #1871 dynamic-array event sources) in the case notes.Reviewed by Cursor Bugbot for commit 0a6b316. Bugbot is set up for automated code reviews on this repo. Configure here.