Use Unlink memory array helpers#58
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cd1f92dda5bbf3aed775a744cba1e3da883c739e_realCommitments/_realNullifiers-shaped memory-array helpersleavesinto an_insertLeaves-shaped helperVerification
git diff --checklake build Benchmark.Cases.UnlinkXyz.Pool.CompileNote
Medium Risk
Updates the Unlink pool model’s leaf/nullifier handling and Merkle-root update path, which could affect state transitions and emitted event metadata. Also bumps the
veritydependency, so behavior may change due to upstream compiler/runtime updates.Overview
The Unlink pool Verity model now materializes Solidity-shaped memory arrays via new
realCommitmentsandrealNullifiershelpers, replacing the prior fused filtering+insertion helper.transferandexecuteWithdrawal/withdraware updated to pass the resultingleavesinto a newinsertLeaveshelper (and to derive event scalar fields from these filtered arrays), while keeping LazyIMT insertion as the same lightweight accumulator boundary.The case metadata is updated to reflect the new assumptions/blockers, and the repo bumps the
veritydependency pin (includinglakefile.lean/lake-manifest.json).Reviewed by Cursor Bugbot for commit f036bc3. Bugbot is set up for automated code reviews on this repo. Configure here.