Add UnlinkPool event metadata#54
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bd211c574f45cda31d66feab1bbc7e9d08dc5486for macro event declarationsevent_defsmetadata for the UnlinkPool interface eventsNotes
dynamic_array_event_payloadsremains unsupported: the event declarations now carry ABI metadata, but the existingemitsites still use scalar surrogate counts until source-faithful dynamic array payload emission is available.Checks
lake build Benchmark.Cases.UnlinkXyz.Pool.Compilegit diff --checkNote
Low Risk
Low risk: changes are limited to adding event metadata declarations and bumping the pinned
veritydependency, without altering contract execution logic.Overview
Adds explicit
event_defsforUnlinkPool(e.g.Deposited,Transferred,Withdrawn, relayer/router events) so event ABI metadata is captured in the macro-generated compilation model.Bumps the pinned
veritydependency tobd211c57…and updates the Unlink pool case manifest (case.yaml) to record the new version and tag (macro_event_declarations).Reviewed by Cursor Bugbot for commit 6fb34f6. Bugbot is set up for automated code reviews on this repo. Configure here.