Skip to content

Add support for differential analyses #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rsarky wants to merge 1 commit into
base: next
Choose a base branch
from
Open

Add support for differential analyses #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions bin/pasta_analyse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ def _evaluate_patch_list_wrapper(thresholds, args):
orig, cand,
parallelise=False)


def find_cherries(repo, commit_hashes, dest_list):
"""
find_cherries() takes a list of commit hashes, a list of potential
Expand Down Expand Up @@ -133,6 +132,10 @@ def analyse(config, argv):
'compare representatives against upstream - '
'(default: %(default)s)')

parser.add_argument('-differential', dest='differential', action='store_true',
default=False,
help='Perform a differential analysis')

args = parser.parse_args(argv)

config.thresholds.heading = args.thres_heading
Expand All @@ -148,6 +151,9 @@ def analyse(config, argv):
log.error('Analysis mode succ is not available in mailbox mode!')
return -1

if not mbox and args.differential:
log.error('Differential analysis can only be performed in mailbox mode')

f_cluster, cluster = config.load_cluster(must_exist=False)

def fill_result(hashes, tag):
Expand All @@ -167,6 +173,7 @@ def fill_result(hashes, tag):
# exists.
config.load_ccache_mbox()

new_patches = set()
if mode == 'rep':
victims = repo.mbox.get_ids(config.mbox_time_window)

Expand Down Expand Up @@ -202,6 +209,9 @@ def fill_result(hashes, tag):
victims = linux_patches
repo.cache_evict_except(victims)


# get new downstream patches since previous analysis
new_patches = victims - cluster.get_downstream()
log.info('Cached %d relevant mails' % len(available))
fill_result(victims, False)

Expand Down Expand Up @@ -275,6 +285,8 @@ def fill_result(hashes, tag):
if unreachable:
remove_from_cluster('COMMITS', cluster, unreachable)

# get new upstream patches since last analysis
new_patches |= candidates - cluster.get_upstream()
fill_result(candidates, True)

config.load_ccache_upstream()
Expand All @@ -295,7 +307,13 @@ def fill_result(hashes, tag):

type = EvaluationType.PatchStack

log.info('Starting evaluation')
if args.differential:
representatives = representatives | new_patches
candidates = new_patches
log.info('Starting differential evaluation of %u new patches' % len(new_patches))
else:
log.info('Starting evaluation')

evaluation_result = evaluate_commit_list(repo, config.thresholds,
mbox, type,
representatives, candidates,
Expand Down