Utility functions to initialize parameters and state variables from a file.#577
Open
edwardalee wants to merge 10 commits intomainfrom
Open
Utility functions to initialize parameters and state variables from a file.#577edwardalee wants to merge 10 commits intomainfrom
edwardalee wants to merge 10 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a small C utility for initializing Lingua Franca C-target parameters/state variables from a delimited text file (e.g., CSV) by reading a selected row and parsing values into provided double* outputs.
Changes:
- Added
lf_initialize_double()API and implementation to read/parse a delimited row into variadicdouble*outputs. - Added a CMake include snippet to compile the new utility source into the main target.
- Fixed documentation examples in deque headers/source to include the missing comma in
target C { ... }examples.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| util/initialize_from_file.h | New public header with usage documentation and lf_initialize_double() declaration |
| util/initialize_from_file.c | Implementation for reading a row, splitting fields, trimming whitespace, and parsing doubles |
| util/initialize_from_file.cmake | Adds the new .c file to the build via target_sources |
| util/deque.h | Doc example tweak (adds missing comma) |
| util/deque.c | Doc example tweak (adds missing comma) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds utility functions to initialize parameters and state variables from a file.
The file can be a CSV file (or use any other single-character delimiter) and the program can choose a row from the file to initialize any number of parameters and/or state variables of the same type from the specified row.
The types supported are double, int, and string.