Skip to content

Support for function update_deadline in Python target#558

Merged
edwardalee merged 12 commits intomainfrom
python-update-deadline
Apr 12, 2026
Merged

Support for function update_deadline in Python target#558
edwardalee merged 12 commits intomainfrom
python-update-deadline

Conversation

@byeonggiljun
Copy link
Copy Markdown
Collaborator

@byeonggiljun byeonggiljun commented Feb 5, 2026

This PR adds the function update_deadline in the Python target.

Companion lingua-franca PR: lingua-franca/pull/2590
Companion lf-python-support: lf-lang/lf-python-support#30

The newly introduced function py_update_deadline parses the deadline value from Python as a double and converts it to uint64_t to support fractional time values (e.g., SEC(0.5)).
Other Python APIs that take time values (e.g., schedule()) raise a type error when given floating-point arguments; extending fractional-time support to those APIs will be done in other PRs.

@byeonggiljun byeonggiljun force-pushed the python-update-deadline branch from bbbeb4e to 3e9e32a Compare February 5, 2026 22:22
@byeonggiljun byeonggiljun requested review from Jakio815, edwardalee and hokeun and removed request for edwardalee February 5, 2026 22:49
Copy link
Copy Markdown
Member

@hokeun hokeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Copy Markdown
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some small editing suggestions...

Copilot AI review requested due to automatic review settings March 27, 2026 22:16

This comment was marked as outdated.

@byeonggiljun byeonggiljun force-pushed the python-update-deadline branch from 602ce0d to 841dbcd Compare March 27, 2026 22:23
byeonggiljun and others added 2 commits March 27, 2026 15:25
@byeonggiljun byeonggiljun force-pushed the python-update-deadline branch from ac62321 to 10e8c01 Compare April 9, 2026 22:37
@byeonggiljun byeonggiljun requested a review from edwardalee April 10, 2026 20:54
Copy link
Copy Markdown
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments need resolving, but otherwise, this looks good!

@edwardalee edwardalee merged commit f76b307 into main Apr 12, 2026
85 of 88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants