Open
Conversation
edwardalee
requested changes
Oct 24, 2024
Contributor
edwardalee
left a comment
edwardalee
left a comment
There was a problem hiding this comment.
This looks to me like an important change. Is there a reason this a draft PR? I’ve made one small suggestion, but otherwise, I think we should merge this.
erlingrj
approved these changes
Oct 28, 2024
Collaborator
erlingrj
left a comment
erlingrj
left a comment
There was a problem hiding this comment.
This looks good to me also.
…ltithreaded-critical-section
Co-authored-by: Edward A. Lee <eal@eecs.berkeley.edu>
Collaborator
|
We need to make disable/enable ISR part of the platform API for threaded applications also. |
edwardalee
approved these changes
Nov 7, 2024
Contributor
edwardalee
left a comment
edwardalee
left a comment
There was a problem hiding this comment.
LGTM. Let's merge this when the tests passs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix for #393
Untested; to make sure this is viable, would need to demonstrate that (1) deadlocks actually occur without this fix, (2) this solves the deadlocks, and (3) there are no forseeable adverse affects from this additional logic.
On most platforms, disabling/enabling interrupts is a no-op, so there should be no performance impact on these platforms.
The main problem with this approach is I don't think it works with enclaves; I remember considering whether interrupts should be disabled for other environments besides the global environment (but it's been a while since I originally wrote this and I've forgotten why I didn't).