Making MIN_SLEEP_DURATION a platform variable and Add busy wait#403
Open
soyerefsane wants to merge 5 commits intomainfrom
Open
Making MIN_SLEEP_DURATION a platform variable and Add busy wait#403soyerefsane wants to merge 5 commits intomainfrom
soyerefsane wants to merge 5 commits intomainfrom
Conversation
Collaborator
Author
|
I made the |
edwardalee
requested changes
Mar 28, 2024
Contributor
edwardalee
left a comment
edwardalee
left a comment
There was a problem hiding this comment.
Good direction. Suggestions added.
| } | ||
|
|
||
| lf_print("---- System clock resolution: %ld nsec", res.tv_nsec); | ||
| MIN_SLEEP_DURATION = NSEC(res.tv_nsec); |
Contributor
There was a problem hiding this comment.
This implementation does not match the description of the PR.
byeonggiljun
force-pushed
the
min-sleep-busy-wait
branch
from
8d2bdd8 to
c2b5f8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #332, I have moved forward to make the following changes for the threaded runtime:
MIN_SLEEP_DURATIONthewait_untilfunction busy waits untilwait_until_timeis reached.MIN_SLEEP_DURATIONwas defined as an arbitrary constant of 10 usec, I changed that to be a platform variable such that the value ofMIN_SLEEP_DURATIONis equal to underlying system's clock resolution.