fix(ci): select an available published Windows bootstrap release - #29
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟡 Changes recommended
Extend duplicate checksum filename detection beyond the Windows asset entry.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Fixes Windows bootstrap CI release selection by choosing the newest published release with valid checksum and binary assets.
Changes:
- Adds stable-tag selection with manifest and binary availability checks.
- Adds PowerShell 5.1 regression coverage.
- Adds a bounded job timeout and installed-version exit validation.
File summaries
| File | Summary |
|---|---|
.github/workflows/ci.yml |
Integrates selection tests and bootstrap validation. |
.github/scripts/test-select-bootstrap-version.ps1 |
Adds Windows regression scenarios. |
.github/scripts/select-bootstrap-version.ps1 |
Selects available Windows releases; duplicate detection must cover all manifest filenames. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+56
to
+60
| if ($lines.Count -eq 0 -or @($lines | Where-Object { $_ -notmatch '^[a-fA-F0-9]{64}\s+\*?\S+$' }).Count -gt 0) { | ||
| throw "Invalid checksum manifest for $tag" | ||
| } | ||
| $assetPattern = [regex]::Escape($asset) | ||
| $entries = @($lines | Where-Object { $_ -match "\s+\*?$assetPattern`$" }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix only the Windows bootstrap CI release-selection bug. This branch is based directly on
mainand does not include the page-target feature in #28.The current
Select-Object -Skip 1assumes that the second-newest tag has published COS assets. Withv1.1.15as the latest tag it selectsv1.1.14, whose Windows binary returns HTTP 404, even though thev1.1.15Windows binary is available. A tag's position does not establish upload completion.Changes
SHA256SUMSWindows entry and an accessible Windows binary before selecting a version. The release uploader publishes the manifest last.No CLI source, Skill installer, version pin, release workflow, dependency, or page-selection behavior is changed.
Validation
1.1.15; the unchanged bootstrap downloads and installs it in an isolated directory, with SHA-256 independently verified andversionreturning1.1.15.windows-bootstrapjob changes. Other CI jobs and the release workflow remain unchanged.git diff --check; product source, Cargo files and Skill files are unchanged.This fixes bootstrap smoke-test selection, not the separate cause of the missing
v1.1.14publication. It does not suppress missing-asset warnings or turn network/integrity failures into successful checks.