Fix create and update super administrator#55
Merged
asengupta3 merged 14 commits intomainfrom Mar 30, 2026
Merged
Conversation
CCuskley
requested changes
Mar 23, 2026
Contributor
CCuskley
left a comment
CCuskley
left a comment
There was a problem hiding this comment.
Minor change that site_admins should be able to view super admins
| // A site admin can change an admin's role (e.g., upgrade them to a site_admin). | ||
| // But a site_admin cannot update another admin's name or email. | ||
| admins: { | ||
| super_admin: [], |
CCuskley
requested changes
Mar 27, 2026
Contributor
CCuskley
left a comment
CCuskley
left a comment
There was a problem hiding this comment.
We need to add claims.super_admin set to true to the userClaims document for full super admin functionality to work. We are hoping to deprecate userClaims entirely, but we're not there yet...
| adminUid: adminUidRaw, | ||
| } = params; | ||
|
|
||
| const customClaims = (requesterRecord.customClaims ?? {}) as Record< |
Contributor
There was a problem hiding this comment.
Found one last issue: userClaims/{adminUid}/claims/super_admin has to be set to true for the useradmin to have full functionality (some assignment queries were failing when logged in as the new superadmin, e.g., showing no assingments in a site that has several). Tested this fix by adding manually with my new superadmin
CCuskley
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
a. This permission core PR: Feat(): Updating package and super admin permissions for admin subresource permissions-core#8
b. Update the systems/permissions doc to include super admin permissions
Types of changes
What types of changes does this pull request introduce?
Additional Notes