feat: list saved PGN positions for active chapter - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24
Summary
Implements CMS-024I by completing the first visible read path for persisted PGN positions.
Saved PGN position snapshots for the active chapter are recovered into a ProjectTab-owned cache and displayed read-only, separately from selected puzzles.
Motivation
CMS-024H completed the write path from PGN review to chapter-scoped persistence. CMS-024I makes that persisted material recoverable and visible after reopening a project, without introducing board loading, editing, deletion, export, or generic editorial abstractions.
Changes
ProjectTab, contextualized by project path + chapter ID.InsertedandAlreadyExistsfrom the SQLite source of truth.Saved PGN positionssection with White, Black, Event, ply, and selected FEN.Validation
cargo fmt --checkcargo clippy --locked --all-targets -- -D warningscargo test --locked— 584 tests passed, 0 ignoredcargo check --locked --all-targetscargo build --lockedgit diff --checkScreenshots
Not required for this task; behavior is covered by ProjectTab state/integration tests.
Database / migration impact
None. CMS-024I reuses project schema v4 and
list_pgn_position_snapshots_for_chapter(...);PROJECT_SCHEMA_VERSIONremains4.Scope
Exactly 8 files:
README.md,src/project_tab.rs, and six translation bundles.No changes to
src/main.rs, PGN review/import code, project persistence, schema/migrations, exports, puzzle persistence, engine, search, favorites, or dependencies.