feat: add captured PGN positions to active chapter - #23
Merged
levallem merged 1 commit intoSep 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22
Summary
Implementa CMS-024H y completa el flujo desde una posición PGN capturada hasta su almacenamiento persistente, delimitado por capítulo, dentro del proyecto activo.
Una posición PGN revisada puede capturarse, conservarse como snapshot reproducible y añadirse al capítulo activo sin convertirla en Puzzle ni acoplar
PgnTaba la persistencia del proyecto.Motivation
Permitir usar posiciones PGN revisadas como material editorial reproducible de un capítulo, preservando los límites existentes entre revisión PGN, coordinación de aplicación y persistencia.
Changes
Add to chaptersólo se habilita cuando existe un snapshot capturado.PgnTabno conoce project path ni chapter ID;ProjectTabconserva ese contexto ymain.rscoordina la operación.InsertedyAlreadyExiststienen feedback distinto.No se introdujo ninguna abstracción editorial genérica. Las posiciones PGN siguen separadas de
Puzzle,ProjectPuzzleDecision, juegos PGN y futuros tipos editoriales. Se reutiliza sin cambios la API de persistencia CMS-024G.Validation
cargo fmt --checkcargo clippy --locked --all-targets -- -D warningscargo test --locked— 574 tests passed; 0 ignoredcargo check --locked --all-targetscargo build --lockedgit diff --checkScreenshots
No aplica: el cambio se validó mediante tests de interacción y persistencia.
Database / migration impact
Ninguno. CMS-024H reutiliza la persistencia schema v4 introducida por CMS-024G;
PROJECT_SCHEMA_VERSIONpermanece en4.Scope
Exactamente 9 archivos:
src/main.rssrc/pgn_tab.rssrc/project_tab.rsSin cambios en
src/project.rs,src/pgn_review.rs, schema o migrations, persistencia de puzzles, export, engine, search, favorites ni dependencias.