feat: persist PGN position snapshots by chapter - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumen
Implementa CMS-024G añadiendo persistencia chapter-scoped para
PgnPositionSnapshotmediante project schema v4.Los snapshots PGN ahora pueden persistirse y recuperarse por capítulo sin integrar todavía UI.
Persistencia
Nueva tabla:
chapter_pgn_positionsConserva:
ImportedGameHeaders.La lectura reconstruye
PgnPositionSnapshoty ejecutavalidate()antes de devolver datos al dominio.Idempotencia
La UNIQUE contextual usa:
Semántica:
Inserted;AlreadyExists;source_game_indexno participa en identidad.selected_fense persiste y valida, pero no participa en deduplicación.Integridad
PROJECT_SCHEMA_VERSION = 4;chapter_id → chapters(id) ON DELETE CASCADE;PRAGMA foreign_keys = ONen las conexiones de proyecto;Scope
Sólo cambian:
src/project.rsproject_migrations/2026-09-22-000000_create_chapter_pgn_positions/up.sqlproject_migrations/2026-09-22-000000_create_chapter_pgn_positions/down.sqlNo hay cambios en:
PgnTab;ProjectTab;main.rs;Validation
cargo fmt --checkcargo clippy --locked --all-targets -- -D warningscargo test --locked— 563 testscargo check --locked --all-targetscargo build --lockedgit diff --checkTodas aprobadas.
Closes #20