feat: add reproducible PGN position snapshots - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementa CMS-024F introduciendo
PgnPositionSnapshot, una representación PGN autocontenida y reproducible completamente en memoria.El snapshot conserva:
ImportedGameHeaders.Puede reconstruir y validar la posición seleccionada sin consultar el PGN original ni una
PgnReviewSessionmutable.Motivation
Cerrar el contrato de dominio de snapshots PGN reproducibles antes de persistencia o integración de UI.
Validation de dominio
PgnPositionSnapshot:ply_index;selected_fencomoBoard;También deriva la jugada anterior y siguiente sin almacenarlas de forma redundante.
Changes
src/pgn_review.rsPgnPositionSnapshot.Scope
Sólo cambia
src/pgn_review.rs.No hay cambios en UI,
PgnTab, proyectos o capítulos, SQLite, schema, migraciones, Puzzle,ProjectPuzzleDecision, exportación PDF/PGN, engine, traducciones ni dependencias.PROJECT_SCHEMA_VERSIONpermanece en 3.Tests
Cobertura añadida para partida estándar,
SetUp/FEN, ply inicial/intermedio/final, partida sin movimientos, conservación de headers, replay exacto, previous/next, FEN inicial inválida, selected FEN inválida, FEN textualmente distinta pero semánticamente equivalente, UCI inválido, movimiento UCI ilegal, movimiento ilegal posterior al ply seleccionado, ply fuera de rango y posición seleccionada inconsistente.Validation
cargo fmt --checkcargo clippy --locked --all-targets -- -D warningscargo test --locked— 552 testscargo check --locked --all-targetscargo build --lockedgit diff --checkTodas aprobadas.
Screenshots
No aplica: no hay cambios visuales.
Database / migration impact
None.
Closes #18