-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[Cleanup] Remove Provisioningxxx fall-back commands and other fixes #5479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mega
Are you sure you want to change the base?
[Cleanup] Remove Provisioningxxx fall-back commands and other fixes #5479
Conversation
|
I did have a look at it with Ton and we came to the conclusion that this isn't something that can be dealt with "quickly". When rewriting all the log stuff, I also added coloring as you may have noticed. So what I did was, I added a LOG_LEVEL_NONE to show the console interactions to be able to color them. In hindsight, this may have been a wrong design choice and it would have been better to set a bit to mark which log entries should be also marked to be easily recognizable. As you can see, this is a bit more than simply not duplicating the logentry lines as you may want to grab attention. The struct holding the log entry is now tightly packed to 32 bits. We can take 1 bit of the log line size, which is still more than enough for any log entry. But it should be something to think about it a bit more as maybe this also affects other things we log. So we're going to fix this, bit for bit :) |
|
Oh and there are a few other things I have planned for the log. |
When we are at it. :) I always wanted to make a FR but it never came to it, so I do it now here. |
Well that's something that could be done at browser level. |
True... could be a task for the one-eyed among the blind :) |

Features:
ProvisionXXXfall-back commands, as all is handled viaProvision,<subcommand>DevSecurity.datthat was still missing=by:in loggingEVENT: xxxin logging forBUILD_NO_DEBUGbuilds (t.b.d.) From this forum threadACT : xxxin logging forBUILD_NO_DEBUGbuilds.