Skip to content

Update changelog for version 1.3.6 and enhance resource handling in PluginEditor and PolyPitchDetector - #8

Merged
leprpht merged 1 commit into
mainfrom
fix-mvp-finalization
Oct 3, 2026
Merged

leprpht merged 1 commit into
mainfrom
fix-mvp-finalization

Conversation

@leprpht

@leprpht leprpht commented Oct 3, 2026

Copy link
Copy Markdown
Owner

This pull request finalizes the realtime MVP review and improves asset handling in both the plugin and UI code, while also refactoring the PitchDetector class for clarity and maintainability. The main changes are grouped below.

Realtime MVP and Asset Handling Improvements:

  • Finalized the realtime MVP review, confirming that per-voice pitch stability, harmonic handling, pluck trigger separation, polyphonic continuity, and continuous input-dynamics are preserved. Automated tests for pitch, trigger, dynamics, analyzer, voice-manager, and processor have been confirmed. (CHANGELOG.md)
  • Embedded UI asset URLs are now relative, and JUCE resource-provider path handling is hardened across WebView2/WebKit, preventing valid bundled assets from being reported as missing. (CHANGELOG.md, Source/PluginEditor.cpp) [1] [2]
  • The Vite config for the UI sets the bundle base to "./" for robust resource-provider compatibility, and asset file naming logic is improved for CSS assets. (UI/vite.config.ts) [1] [2]

Code Quality and Refactoring:

  • The PitchDetector class in Source/PolyPitchDetector.h is refactored to use consistent brace and formatting style (K&R), with improved clarity and modern C++ idioms. All methods are now defined inline, and conditionals are simplified for readability and maintainability. (Source/PolyPitchDetector.h) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

@leprpht
leprpht merged commit 0d474dd into main Oct 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant