Repository navigation
Update changelog for version 1.3.6 and enhance resource handling in PluginEditor and PolyPitchDetector - #8
Merged
Merged
Conversation
…luginEditor and PolyPitchDetector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request finalizes the realtime MVP review and improves asset handling in both the plugin and UI code, while also refactoring the
PitchDetectorclass for clarity and maintainability. The main changes are grouped below.Realtime MVP and Asset Handling Improvements:
CHANGELOG.md)CHANGELOG.md,Source/PluginEditor.cpp) [1] [2]"./"for robust resource-provider compatibility, and asset file naming logic is improved for CSS assets. (UI/vite.config.ts) [1] [2]Code Quality and Refactoring:
PitchDetectorclass inSource/PolyPitchDetector.his refactored to use consistent brace and formatting style (K&R), with improved clarity and modern C++ idioms. All methods are now defined inline, and conditionals are simplified for readability and maintainability. (Source/PolyPitchDetector.h) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]