Repository navigation
Keep raw cursor transaction calls and attribute lookups as they were - #232
Merged
Merged
Conversation
Routing raw DBAPI cursor calls through the connection wrapper also changed begin(), commit() and rollback(), which stopped opening a transaction under AUTOCOMMIT, and buffered an open result on a bare attribute lookup. Leave the transaction calls to DuckDB and buffer only when a routed method is called. Correct the duckdb_sequence_name advice for reflected tables.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A review of the unreleased changes found two regressions from routing raw DBAPI cursor calls through the connection wrapper in #230:
begin(),commit()androllback()on a DBAPI cursor resolved to the wrapper's methods. Underisolation_level="AUTOCOMMIT"cursor.begin()no longer opened a transaction, and the calls returnedNoneinstead of the DuckDB connection. They are DuckDB's own methods again.hasattr(cursor, "register")does, buffered the open result. The buffering now happens when the method is called.Documentation for
duckdb_sequence_name:nextval()default removed before the option is set. The previous advice raisedCompileError.CompileErrorcheck applies per table.Tests
Two new end-to-end tests fail on
mainand pass here. Full suite: