Skip to content

Fail the MotherDuck workflow without credentials and refresh the test matrix - #231

Merged
leonardovida merged 1 commit into
mainfrom
chore/ci-and-docs-upkeep
Nov 17, 2026
Merged

leonardovida merged 1 commit into
mainfrom
chore/ci-and-docs-upkeep

Conversation

@leonardovida

Copy link
Copy Markdown
Owner

Summary

  • The weekly MotherDuck integration workflow fails when the MOTHERDUCK_TOKEN secret is missing. It previously passed in a few seconds without running a test. It installs duckdb>=1.4.1,<2 unless MOTHERDUCK_DUCKDB_VERSION selects a version, because MotherDuck rejects DuckDB 2.x clients.
  • The nox matrix moves to SQLAlchemy 2.0.58 and 2.1.9. README and CLAUDE.md name the new versions and the duckdb_2_0 CI job.
  • The benchmark job writes a table of timings and peak memory against the baseline commit to its run summary through the new benchmarks/compare.py. The table is informational.
  • Two stale TODO comments are removed. div_is_floordiv = False is correct for every supported DuckDB version.

The scheduled MotherDuck run stays red until the MOTHERDUCK_TOKEN repository secret is added.

Tests

  • Full suite on DuckDB 1.5.6 with SQLAlchemy 2.0.58, Python 3.12: 921 passed, 10 skipped
  • benchmarks/compare.py run locally on two reports from benchmarks/run.py

… matrix

Make the weekly MotherDuck workflow fail when MOTHERDUCK_TOKEN is missing and keep it on a DuckDB version MotherDuck accepts. Move the nox matrix to SQLAlchemy 2.0.58 and 2.1.9, summarize benchmark timings against the baseline commit, and drop two stale TODO comments.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T15:48:46.219714Z 18e5b1e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@leonardovida
leonardovida merged commit 846b4a5 into main Nov 17, 2026
32 checks passed
@leonardovida
leonardovida deleted the chore/ci-and-docs-upkeep branch November 17, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant