Repository navigation
Fail the MotherDuck workflow without credentials and refresh the test matrix - #231
Merged
Merged
Conversation
… matrix Make the weekly MotherDuck workflow fail when MOTHERDUCK_TOKEN is missing and keep it on a DuckDB version MotherDuck accepts. Move the nox matrix to SQLAlchemy 2.0.58 and 2.1.9, summarize benchmark timings against the baseline commit, and drop two stale TODO comments.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MOTHERDUCK_TOKENsecret is missing. It previously passed in a few seconds without running a test. It installsduckdb>=1.4.1,<2unlessMOTHERDUCK_DUCKDB_VERSIONselects a version, because MotherDuck rejects DuckDB 2.x clients.noxmatrix moves to SQLAlchemy 2.0.58 and 2.1.9. README andCLAUDE.mdname the new versions and theduckdb_2_0CI job.benchmarks/compare.py. The table is informational.div_is_floordiv = Falseis correct for every supported DuckDB version.The scheduled MotherDuck run stays red until the
MOTHERDUCK_TOKENrepository secret is added.Tests
benchmarks/compare.pyrun locally on two reports frombenchmarks/run.py