Repository navigation
feat/chinese support - #17
Merged
Merged
Conversation
leolaurindo
commented
Sep 28, 2026
leolaurindo
commented
Owner
- Preserve unicode letters in property names
- Add Chinese README
- add note to README.md
sanitizeProperty stripped every non-ASCII character, so Chinese table headers and field names collapsed to the property fallback. Distinct headers such as 作者 and 年份 then collided into one key, silently dropping data. Allow unicode letters and numbers (u flag) while still normalizing spaces, dashes, and punctuation. Add coverage for CJK property keys surviving note frontmatter and base output.
Add README.zh.md, a Chinese translation generated entirely by AI. It notes that it may contain errors and points to the English README as the source of truth. Cross-link the two READMEs and localize the examples: Chinese names for the list items and for the books that have Chinese editions, plus a neutral replacement for the milk example. Document that CJK property names are preserved by normalization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.