Repository navigation
Pin shared workflows to v1.2.3 (ADR-0005) - #209
Merged
Merged
Conversation
Part of lentago/shared-workflows#64 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cpitzi
enabled auto-merge (squash)
October 6, 2026 19:53
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of lentago/shared-workflows#64
Summary
lentago/shared-workflows ADR-0005 (
docs/adr/0005-immutable-semver-tags-replace-main-consumption.md) requires callers to consume reusable workflows at immutable semver tags rather than@main, so an upstream change cannot alter this repo's CI without a reviewed bump here.v1.2.3(shared-workflows commit 43b4fe4) is used rather thanv1.2.2because it carries the Dependabot action bumps merged afterv1.2.2(shared-workflows#56, #59); pinning tov1.2.2would roll those back for callers currently trackingmain.claude.ymlanddocs-check.ymlmove from@mainto@v1.2.3.tf-lint.ymlis already on a tag (@v1.2.2) and is left as is; third-party SHA pins are untouched..github/workflows/claude-code-review.ymlis deleted. It has beenworkflow_dispatch-only since 2026-06-25, CodeRabbit is now the org-wide advisory reviewer, and the stub is not a required status context (checked againstdotgithub/fleet-ops/required-checks.jsonand the livemainruleset)..github/workflows/shellcheck.ymlcallsshellcheck.yml@v1.2.3onpull_request(opened, synchronize, ready_for_review, reopened) with noon:path filter, mirroring kalmia's caller. Noscriptsinput is passed, so the reusable discovers every tracked*.sh. Tracked scripts:modules/alb-log-shipper/build.sh,scripts/bootstrap/bootstrap-backend.sh,scripts/setup-crostini-lab.sh,scripts/standup.sh,scripts/teardown.sh.Verification
Local
shellcheck --severity=warning --shell=bash(0.11.0) passes on all five tracked scripts; localgrepconfirms no@mainshared-workflows refs remain; the v1.2.3 docs link checker passes locally. This is a CI-only change, so the terraformchangesjob should skip plan/apply.🤖 Generated with Claude Code