[FIX] spreadsheet_oca: 19.0 empty ListView.Buttons breaks Spreadsheets list (OwlError)#4
Open
dnplkndll wants to merge 1 commit into
Conversation
19.0 core emptied the web.ListView.Buttons template (now self-closing, like
web.KanbanView.Buttons), so the xpath //div[hasclass('o_list_buttons')]
resolves to nothing and OWL throws at render of the Spreadsheets list view.
Target the template root (expr="." position="inside") — the pattern core
hr_expense/data_recycle use to add buttons to the emptied template.
Browser-only failure; Python CI stays green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix on top of OCA#109.
Problem
Opening the Spreadsheets list view (
spreadsheet.spreadsheet) throws an OWL lifecycle error on 19.0:Element '<xpath expr="//div[hasclass('o_list_buttons')]" …>' cannot be located in element tree.19.0 core emptied
web.ListView.Buttons(now<t t-name="web.ListView.Buttons"/>, same asweb.KanbanView.Buttons), so the module's xpath intoo_list_buttonsresolves to nothing. Browser-only — Python CI never renders the view, so it stays green.Fix
One line: target the template root with
expr="." position="inside"— the exact pattern 19.0 corehr_expense/data_recycleuse to add buttons to the emptiedListView.Buttons.Verified on a 19.0 instance: Spreadsheets list renders, the Upload button appears next to New, no OWL error.