Skip to content

[20.0][OU-ADD] hr_attendance: migration scripts #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dnplkndll wants to merge 1 commit into
base: 20.0
Choose a base branch
from
Draft

[20.0][OU-ADD] hr_attendance: migration scripts #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docsource/modules190-200.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ Module coverage 19.0 -> 20.0
+---------------------------------------------------+----------------------+-------------------------------------------------+
| hr | | |
+---------------------------------------------------+----------------------+-------------------------------------------------+
| hr_attendance | | |
| hr_attendance |Done | |
+---------------------------------------------------+----------------------+-------------------------------------------------+
| hr_calendar | | |
+---------------------------------------------------+----------------------+-------------------------------------------------+
Expand Down
32 changes: 32 additions & 0 deletions openupgrade_scripts/scripts/hr_attendance/20.0.2.0/post-migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Copyright 2026 Don Kendall
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).

from openupgradelib import openupgrade

_legacy_validation = openupgrade.get_legacy_name("attendance_overtime_validation")


@openupgrade.migrate()
def migrate(env, version):
"""Carry whether extra hours need approving into 20.0's wider question.

19.0 asked no_validation or by_manager. 20.0 asks no_validation,
manual_validation or tolerance_validation, under a new name and so in a new
column that takes the default. A company that required a manager to approve
extra hours therefore comes out approving them automatically, and nothing
says so: the setting is not shown as empty, it is shown as the other answer.

Only by_manager is written. no_validation is already what the default gives,
and tolerance_validation is 20.0's new middle ground, which no 19.0 database
can have chosen.
"""
if not openupgrade.column_exists(env.cr, "res_company", _legacy_validation):
return
openupgrade.logged_query(
env.cr,
f"""
UPDATE res_company
SET attendance_validation = 'manual_validation'
WHERE {_legacy_validation} = 'by_manager'
""",
)
19 changes: 19 additions & 0 deletions openupgrade_scripts/scripts/hr_attendance/20.0.2.0/pre-migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Copyright 2026 Don Kendall
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).

from openupgradelib import openupgrade


@openupgrade.migrate()
def migrate(env, version):
# 19.0's attendance_overtime_validation said whether extra hours needed a
# manager's approval. 20.0 asks the same question under a different name,
# attendance_validation, with a third answer added. Being a different
# column, it takes its own default and the answer is not carried, so
# post-migration reads this one back.
if openupgrade.column_exists(
env.cr, "res_company", "attendance_overtime_validation"
):
openupgrade.rename_columns(
env.cr, {"res_company": [("attendance_overtime_validation", None)]}
)
138 changes: 138 additions & 0 deletions openupgrade_scripts/scripts/hr_attendance/20.0.2.0/upgrade_analysis.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,138 @@
---Models in module 'hr_attendance'---
obsolete model hr.attendance.overtime.line
obsolete model hr.attendance.overtime.rule
obsolete model hr.attendance.overtime.ruleset
---Fields in module 'hr_attendance'---
hr_attendance / hr.attendance / break_duration (float) : NEW
hr_attendance / hr.attendance / day_of_date (selection) : NEW selection_keys: ['0', '1', '2', '3', '4', '5', '6'], isfunction: function, stored
hr_attendance / hr.attendance / expected_hours (float) : DEL
hr_attendance / hr.attendance / in_image (binary) : NEW attachment: True
hr_attendance / hr.attendance / linked_overtime_ids (many2many): DEL relation: hr.attendance.overtime.line, stored: False
hr_attendance / hr.attendance / overtime_attendance_ids (one2many): NEW relation: hr.attendance
hr_attendance / hr.attendance / overtime_hours (float) : DEL
hr_attendance / hr.attendance / overtime_status (selection) : DEL selection_keys: ['approved', 'refused', 'to_approve']
hr_attendance / hr.attendance / source_attendance_id (many2one): NEW relation: hr.attendance
hr_attendance / hr.attendance / source_stale (boolean) : NEW hasdefault: default
hr_attendance / hr.attendance / state (selection) : NEW required, selection_keys: ['draft', 'refused', 'validated']
hr_attendance / hr.attendance / time_rule_id (many2one) : NEW relation: hr.time.rule
hr_attendance / hr.attendance / validated_overtime_hours (float): DEL
hr_attendance / hr.attendance / website_message_ids (one2many): DEL relation: mail.message
hr_attendance / hr.attendance / work_entry_type_id (many2one) : NEW relation: hr.work.entry.type, required, hasdefault: default
hr_attendance / hr.attendance.overtime.line / amount_rate (float) : DEL required
hr_attendance / hr.attendance.overtime.line / date (date) : DEL required
hr_attendance / hr.attendance.overtime.line / duration (float) : DEL required
hr_attendance / hr.attendance.overtime.line / employee_id (many2one) : DEL relation: hr.employee, required
hr_attendance / hr.attendance.overtime.line / manual_duration (float) : DEL
hr_attendance / hr.attendance.overtime.line / rule_ids (many2many) : DEL relation: hr.attendance.overtime.rule
hr_attendance / hr.attendance.overtime.line / status (selection) : DEL required, selection_keys: ['approved', 'refused', 'to_approve']
hr_attendance / hr.attendance.overtime.line / time_start (datetime) : DEL
hr_attendance / hr.attendance.overtime.line / time_stop (datetime) : DEL
hr_attendance / hr.attendance.overtime.rule / amount_rate (float) : DEL
hr_attendance / hr.attendance.overtime.rule / base_off (selection) : DEL required, selection_keys: ['quantity', 'timing']
hr_attendance / hr.attendance.overtime.rule / description (html) : DEL
hr_attendance / hr.attendance.overtime.rule / employee_tolerance (float) : DEL
hr_attendance / hr.attendance.overtime.rule / employer_tolerance (float) : DEL
hr_attendance / hr.attendance.overtime.rule / expected_hours (float) : DEL
hr_attendance / hr.attendance.overtime.rule / expected_hours_from_contract (boolean): DEL
hr_attendance / hr.attendance.overtime.rule / name (char) : DEL required
hr_attendance / hr.attendance.overtime.rule / paid (boolean) : DEL
hr_attendance / hr.attendance.overtime.rule / quantity_period (selection) : DEL selection_keys: ['day', 'week']
hr_attendance / hr.attendance.overtime.rule / resource_calendar_id (many2one): DEL relation: resource.calendar
hr_attendance / hr.attendance.overtime.rule / ruleset_id (many2one) : DEL relation: hr.attendance.overtime.ruleset, required
hr_attendance / hr.attendance.overtime.rule / sequence (integer) : DEL
hr_attendance / hr.attendance.overtime.rule / timing_start (float) : DEL
hr_attendance / hr.attendance.overtime.rule / timing_stop (float) : DEL
hr_attendance / hr.attendance.overtime.rule / timing_type (selection) : DEL selection_keys: ['leave', 'non_work_days', 'schedule', 'work_days']
hr_attendance / hr.attendance.overtime.ruleset / active (boolean) : DEL
hr_attendance / hr.attendance.overtime.ruleset / company_id (many2one) : DEL relation: res.company
hr_attendance / hr.attendance.overtime.ruleset / country_id (many2one) : DEL relation: res.country
hr_attendance / hr.attendance.overtime.ruleset / description (html) : DEL
hr_attendance / hr.attendance.overtime.ruleset / name (char) : DEL required
hr_attendance / hr.attendance.overtime.ruleset / rate_combination_mode (selection): DEL required, selection_keys: ['max', 'sum']
hr_attendance / hr.attendance.overtime.ruleset / rule_ids (one2many) : DEL relation: hr.attendance.overtime.rule
hr_attendance / hr.employee / overtime_ids (one2many) : DEL relation: hr.attendance.overtime.line
hr_attendance / hr.time.rule / condition_work_entry_type_ids (False): NEW mode: modify, hasdefault: default
hr_attendance / hr.version / attendance_based (boolean) : NEW hasdefault: default
hr_attendance / hr.version / ruleset_id (many2one) : DEL relation: hr.attendance.overtime.ruleset
hr_attendance / res.company / attendance_based (boolean) : NEW hasdefault: default
hr_attendance / res.company / attendance_break_management (boolean): NEW
hr_attendance / res.company / attendance_capture_check_in (boolean): NEW hasdefault: default
hr_attendance / res.company / attendance_overtime_validation (selection): DEL selection_keys: ['by_manager', 'no_validation']
hr_attendance / res.company / attendance_validation (selection): NEW selection_keys: ['manual_validation', 'no_validation', 'tolerance_validation'], hasdefault: default
hr_attendance / res.company / attendance_validation_tolerance (float): NEW hasdefault: default
hr_attendance / res.company / attendance_work_entry_type_id (many2one): NEW relation: hr.work.entry.type, hasdefault: compute
hr_attendance / res.company / auto_check_out_mode (selection): NEW selection_keys: ['specific_time', 'tolerance'], hasdefault: default
hr_attendance / res.company / auto_check_out_specific_time (float): NEW hasdefault: default
hr_attendance / res.company / hr_attendance_display_overtime (boolean): DEL
hr_attendance / res.company / overtime_company_threshold (integer): DEL
hr_attendance / res.company / overtime_employee_threshold (integer): DEL
hr_attendance / res.company / single_check_in (boolean) : NEW
---XML records in module 'hr_attendance'---
DEL hr.attendance.overtime.rule: hr_attendance.hr_attendance_overtime_employee_schedule_rule (noupdate)
DEL hr.attendance.overtime.rule: hr_attendance.hr_attendance_overtime_non_working_days_rule (noupdate)
DEL hr.attendance.overtime.rule: hr_attendance.hr_attendance_overtime_rule_1_ae (noupdate)
DEL hr.attendance.overtime.rule: hr_attendance.hr_attendance_overtime_rule_2_ae (noupdate)
DEL hr.attendance.overtime.rule: hr_attendance.hr_attendance_overtime_rule_3_ae (noupdate)
DEL hr.attendance.overtime.rule: hr_attendance.hr_attendance_overtime_rule_4_ae (noupdate)
DEL hr.attendance.overtime.ruleset: hr_attendance.hr_attendance_default_ruleset (noupdate)
DEL hr.attendance.overtime.ruleset: hr_attendance.l10n_ae_hr_attendance_overtime_ruleset (noupdate)
NEW ir.access: hr_attendance.access_hr_time_rule_attendance_admin
NEW ir.access: hr_attendance.hr_attendance_rule_attendance_admin
NEW ir.access: hr_attendance.hr_attendance_rule_attendance_manager_restrict
NEW ir.access: hr_attendance.hr_attendance_rule_attendance_own
NEW ir.access: hr_attendance.hr_attendance_rule_attendance_simple_user
NEW ir.access: hr_attendance.hr_attendance_rule_employee_company
ir.actions.act_window: hr_attendance.hr_attendance_management_action (deleted domain)
NEW ir.actions.act_window: hr_attendance.hr_attendance_my_action
DEL ir.actions.act_window: hr_attendance.hr_attendance_overtime_rule_action
DEL ir.actions.act_window: hr_attendance.hr_attendance_overtime_ruleset_action
NEW ir.actions.server: hr_attendance.action_attendance_refuse
NEW ir.actions.server: hr_attendance.action_attendance_validate
NEW ir.cron: hr_attendance.hr_attendance_day_undertime_rules_cron
NEW ir.cron: hr_attendance.hr_attendance_week_time_rules_cron
DEL ir.model.access: hr_attendance.access_hr_attendance_admin
DEL ir.model.access: hr_attendance.access_hr_attendance_officer
DEL ir.model.access: hr_attendance.access_hr_attendance_overtime_line_officer
DEL ir.model.access: hr_attendance.access_hr_attendance_overtime_line_own_reader
DEL ir.model.access: hr_attendance.access_hr_attendance_overtime_rule_admin
DEL ir.model.access: hr_attendance.access_hr_attendance_overtime_rule_officer
DEL ir.model.access: hr_attendance.access_hr_attendance_overtime_rule_user
DEL ir.model.access: hr_attendance.access_hr_attendance_overtime_ruleset_admin
DEL ir.model.access: hr_attendance.access_hr_attendance_overtime_ruleset_hr_manager
DEL ir.model.access: hr_attendance.access_hr_attendance_own_reader
DEL ir.model.access: hr_attendance.access_hr_attendance_user
NEW ir.model.constraint: hr_attendance.constraint_res_company_check_auto_check_out_specific_time_range
DEL ir.model.constraint: hr_attendance.constraint_hr_attendance_overtime_line_overtime_start_before_end
DEL ir.model.constraint: hr_attendance.constraint_hr_attendance_overtime_rule_timing_start_is_hour
DEL ir.model.constraint: hr_attendance.constraint_hr_attendance_overtime_rule_timing_stop_is_hour
DEL ir.rule: hr_attendance.hr_attendance_overtime_line_rule_admin (noupdate)
DEL ir.rule: hr_attendance.hr_attendance_overtime_line_rule_employee_company (noupdate)
DEL ir.rule: hr_attendance.hr_attendance_overtime_line_rule_officer (noupdate)
DEL ir.rule: hr_attendance.hr_attendance_overtime_line_rule_own_reader (noupdate)
DEL ir.rule: hr_attendance.hr_attendance_overtime_ruleset_rule (noupdate)
DEL ir.rule: hr_attendance.hr_attendance_overtime_ruleset_rule_group_hr_attendance_manager (noupdate)
DEL ir.rule: hr_attendance.hr_attendance_rule_attendance_admin (noupdate)
DEL ir.rule: hr_attendance.hr_attendance_rule_attendance_manager_restrict (noupdate)
DEL ir.rule: hr_attendance.hr_attendance_rule_attendance_simple_user (noupdate)
DEL ir.rule: hr_attendance.hr_attendance_rule_employee_company (noupdate)
NEW ir.ui.menu: hr_attendance.menu_hr_attendance_management_list
NEW ir.ui.menu: hr_attendance.menu_hr_attendance_my_attendances
NEW ir.ui.menu: hr_attendance.menu_hr_attendance_time_rules
NEW ir.ui.menu: hr_attendance.menu_hr_attendance_work_entry_type
DEL ir.ui.menu: hr_attendance.menu_hr_attendance_overtime_rulesets
DEL ir.ui.menu: hr_attendance.menu_hr_attendance_overview
NEW ir.ui.view: hr_attendance.hr_attendance_create_view_form
NEW ir.ui.view: hr_attendance.hr_attendance_employee_calendar_view
NEW ir.ui.view: hr_attendance.hr_attendance_my_calendar_view
NEW ir.ui.view: hr_attendance.hr_attendance_my_form_view
NEW ir.ui.view: hr_attendance.hr_contract_template_view_form
NEW ir.ui.view: hr_attendance.hr_version_list_view_enhanced_hr_attendance_base
NEW ir.ui.view: hr_attendance.hr_version_search_view_enhanced_hr_attendance
DEL ir.ui.view: hr_attendance.hr_attendance_employee_simple_tree_view
DEL ir.ui.view: hr_attendance.hr_attendance_overtime_rule_view_form
DEL ir.ui.view: hr_attendance.hr_attendance_overtime_rule_view_list
DEL ir.ui.view: hr_attendance.hr_attendance_overtime_ruleset_view_filter
DEL ir.ui.view: hr_attendance.hr_attendance_overtime_ruleset_view_form
DEL ir.ui.view: hr_attendance.hr_attendance_overtime_ruleset_view_list
res.groups: base.group_user (noupdate switched)
NEW res.groups: hr_attendance.group_hr_attendance_own
Loading
Loading