Repository navigation
Conversation
Every line in these modules' analysis resolves without a migration script, and the work files say which rule each line falls under rather than carrying a bare marker. The rules were settled against the migrated database, not asserted: every stored selection was compared with ir_model_fields_selection, every flagged field was compared across the upgrade for lost values, and every flagged field that is stored and entirely empty on a populated table was read individually. noupdate records the module stops shipping are left in place -- _process_end only removes stale rows whose noupdate is false, and orphan cleanup is the anti-pattern upstream rejected in OCA#5630-5632. 6 modules. Assisted-by: Claude Opus 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every line in these modules' analysis resolves without a migration script, and
the work files say which rule each line falls under rather than carrying a bare
marker.
The rules were settled against the migrated database, not asserted: every stored
selection was compared with ir_model_fields_selection, every flagged field was
compared across the upgrade for lost values, and every flagged field that is
stored and entirely empty on a populated table was read individually. noupdate
records the module stops shipping are left in place -- _process_end only removes
stale rows whose noupdate is false, and orphan cleanup is the anti-pattern
upstream rejected in OCA#5630-5632.
6 modules.
CI: red until #118 lands
The
testjob fails onduplicate key value violates unique constraint "res_country_state_name_code_uniq"(Ladakh / Odisha). Not this branch:base's pre-migration, which renames those two external ids, lives in #118 andis not on
20.0yet, so every branch cut from20.0alone hits it. Per thefork's model the per-PR check is the lean one; the real migration gate is the
integration branch (#120), where all of this runs green over the full
585-module seed.
AI-assisted (Claude Code); every change reviewed, tested, and owned by the author.