Repository navigation
Conversation
dnplkndll
force-pushed
the
20.0-fix-noupdate-load-data
branch
from
September 23, 2026 21:26
5091772 to
d5cf20e
Compare
The analysis generated a noupdate_changes.xml for each of these and nothing loaded any of them. A module update skips noupdate records by definition, so those record changes only reach an existing database through an explicit openupgrade.load_data call -- the upgrade ran green while delivering none of them. 30 of the files reload a translatable field. That writes the source term and nothing else, so the stale per-language translations keep the 19.0 wording and Odoo serves those to every non-English user: the reload lands for English and is silently undone for everyone else. Each of those load_data calls is paired with delete_record_translations naming only the fields that record actually reloads, derived from the 20.0 registry rather than guessed. One change with one reason, which is the exception the playbook allows to one module per PR. website_sale, hr_attendance, fleet and maintenance were in an earlier revision of this branch and are not here: both have since grown a substantive script, so each carries its load_data call in its own PR rather than in this mechanical batch. Assisted-by: Claude Opus 5
dnplkndll
force-pushed
the
20.0-fix-noupdate-load-data
branch
from
September 23, 2026 22:47
d5cf20e to
0159f91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The analysis generated a noupdate_changes.xml for each of these and nothing
loaded any of them. A module update skips noupdate records by definition, so
those record changes only reach an existing database through an explicit
openupgrade.load_data call -- the upgrade ran green while delivering none of
them.
30 of the files reload a translatable field. That writes the source term and
nothing else, so the stale per-language translations keep the 19.0 wording and
Odoo serves those to every non-English user: the reload lands for English and is
silently undone for everyone else. Each of those load_data calls is paired with
delete_record_translations naming only the fields that record actually reloads,
derived from the 20.0 registry rather than guessed.
One change with one reason, which is the exception the playbook allows to
one module per PR.
CI: red until #118 lands
The
testjob fails onduplicate key value violates unique constraint "res_country_state_name_code_uniq"(Ladakh / Odisha). Not this branch:base's pre-migration, which renames those two external ids, lives in #118 andis not on
20.0yet, so every branch cut from20.0alone hits it. Per thefork's model the per-PR check is the lean one; the real migration gate is the
integration branch (#120), where all of this runs green over the full
585-module seed.
AI-assisted (Claude Code); every change reviewed, tested, and owned by the author.
Scope correction
website_sale,hr_attendance,fleetandmaintenancewere in earlier revisions of thisbranch and are no longer here: each has since grown a substantive migration script, so each
carries its own
load_datacall in its own PR (#167, #168, #169, #170) rather than in thismechanical batch. 57 modules remain.