Repository navigation
Conversation
### post-migration.py Point the French reference leave type at its 20.0 stand-in. res.company.l10n_fr_reference_leave_type referenced hr.leave.type, which 20.0 folds into hr.work.entry.type; the replacement is l10n_fr_reference_work_entry_type. This lives here rather than with the rest of that fold in hr_holidays because of load order: hr_holidays runs at module 234 of 563 and l10n_fr_hr_holidays at 361, so when hr_holidays' post-migration runs the new column does not exist yet. Its column_exists guard skipped the update silently -- no error, no value, and the company's reference type quietly lost. Doing it from the module that owns the column removes the ordering question entirely. Assisted-by: Claude Opus 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
post-migration.py
Point the French reference leave type at its 20.0 stand-in.
res.company.l10n_fr_reference_leave_type referenced hr.leave.type, which
20.0 folds into hr.work.entry.type; the replacement is
l10n_fr_reference_work_entry_type.
This lives here rather than with the rest of that fold in hr_holidays
because of load order: hr_holidays runs at module 234 of 563 and
l10n_fr_hr_holidays at 361, so when hr_holidays' post-migration runs the new
column does not exist yet. Its column_exists guard skipped the update
silently -- no error, no value, and the company's reference type quietly
lost. Doing it from the module that owns the column removes the ordering
question entirely.
CI: red until #118 lands
The
testjob fails onduplicate key value violates unique constraint "res_country_state_name_code_uniq"(Ladakh / Odisha). Not this branch:base's pre-migration, which renames those two external ids, lives in #118 andis not on
20.0yet, so every branch cut from20.0alone hits it. Per thefork's model the per-PR check is the lean one; the real migration gate is the
integration branch (#120), where all of this runs green over the full
585-module seed.
AI-assisted (Claude Code); every change reviewed, tested, and owned by the author.