Repository navigation
Conversation
### post-migration.py Say which versions classified the person in a way 20.0 cannot hold. 19.0 had two fields: contract_type_id, which pre-migration renames to employee_type_id because that is what 20.0 kept, and employee_type, a required selection of Employee, Worker, Student, Trainee, Contractor and Freelancer with Employee as its default. The selection is not mapped onto an hr.employee.type. They classify different things -- what the person is against what the contract is -- and the records to map onto are 19.0's own contract types, so writing Student into a version that never had a contract type would invent configuration rather than carry it. Only the values someone chose are worth a line: the default says nothing, and every version on the seed is on it. Assisted-by: Claude Opus 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
post-migration.py
Say which versions classified the person in a way 20.0 cannot hold.
19.0 had two fields: contract_type_id, which pre-migration renames to
employee_type_id because that is what 20.0 kept, and employee_type, a
required selection of Employee, Worker, Student, Trainee, Contractor and
Freelancer with Employee as its default.
The selection is not mapped onto an hr.employee.type. They classify
different things -- what the person is against what the contract is -- and
the records to map onto are 19.0's own contract types, so writing Student
into a version that never had a contract type would invent configuration
rather than carry it. Only the values someone chose are worth a line: the
default says nothing, and every version on the seed is on it.
CI: red until #118 lands
The
testjob fails onduplicate key value violates unique constraint "res_country_state_name_code_uniq"(Ladakh / Odisha). Not this branch:base's pre-migration, which renames those two external ids, lives in #118 andis not on
20.0yet, so every branch cut from20.0alone hits it. Per thefork's model the per-PR check is the lean one; the real migration gate is the
integration branch (#120), where all of this runs green over the full
585-module seed.
AI-assisted (Claude Code); every change reviewed, tested, and owned by the author.