Fix setup_acados.sh#90
Open
N0OBSTUDENT wants to merge 1 commit into
Open
Conversation
The former acados setup script OVERWRITE the whole environment variable LD_LIBRARY_PATH, making other library paths not accessible.
ratheron
reviewed
May 11, 2026
| export ACADOS_SOURCE_DIR="$ACADOS_DIR" | ||
| export ACADOS_INSTALL_DIR="$ACADOS_DIR" | ||
| export LD_LIBRARY_PATH="$ACADOS_DIR/lib" | ||
| export LD_LIBRARY_PATH="$ACADOS_DIR/lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}" |
Collaborator
There was a problem hiding this comment.
Does this work even if the LD_LIBRARY_PATH is not set?
Collaborator
Author
There was a problem hiding this comment.
Yes, I suppose this is equivalent to something like
LD_LIBRARY_PATH = f"{ACADOS_DIR}/lib" + (f":{LD_LIBRARY_PATH}" if LD_LIBRARY else "")
in python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The former acados setup script OVERWRITEs the whole environment variable LD_LIBRARY_PATH, making other library paths not visible.