Skip to content

Pass DOCKERHUB_TOKEN to the container image publish reusable workflow#14767

Open
rtibbles wants to merge 1 commit into
learningequality:developfrom
rtibbles:pass-dockerhub-token-to-container-publish
Open

Pass DOCKERHUB_TOKEN to the container image publish reusable workflow#14767
rtibbles wants to merge 1 commit into
learningequality:developfrom
rtibbles:pass-dockerhub-token-to-container-publish

Conversation

@rtibbles
Copy link
Copy Markdown
Member

Summary

  • Reusable workflows don't inherit the caller's secrets
  • Docker Hub login got an empty password → Password required
  • Declare DOCKERHUB_TOKEN in workflow_call, pass it from the release workflow

References

Reviewer guidance

  • Same secret-passing pattern as pypi_upload and android_release

AI usage

  • Claude Code diagnosed the failure from CI logs and wrote the fix; I reviewed it.

Reusable workflows do not inherit caller secrets automatically, so the
Docker Hub login in container_image_publish.yml received an empty
password and failed with "Password required" during release. Declare the
secret in the workflow_call interface and pass it from the release
workflow, matching how pypi_upload and android_release pass their
secrets.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added DEV: dev-ops Continuous integration & deployment SIZE: very small labels May 27, 2026
@rtibbles rtibbles marked this pull request as ready for review May 27, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DEV: dev-ops Continuous integration & deployment SIZE: very small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant