Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/eslint-plugin-kolibri/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"directory": "packages/eslint-plugin-kolibri"
},
"dependencies": {
"eslint-plugin-vue": "^9.33.0",
"eslint-plugin-vue": "^10.8.0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking: This major version bump breaks Kolibri's custom ESLint plugin. eslint-plugin-vue v10 removed the internal lib/utils module path, which is imported by 11 files in packages/eslint-plugin-kolibri/lib/. Both CI linting and frontend tests fail with Cannot find module 'eslint-plugin-vue/lib/utils'.

Additionally, v10 requires vue-eslint-parser@^10.0.0 as a peer dependency, but the lockfile resolves to v9.4.3.

This upgrade needs a companion code migration:

  1. Find the v10-equivalent public API for the utils that eslint-plugin-kolibri uses (likely eslint-plugin-vue/lib/utils was restructured or re-exported differently)
  2. Update all 11 import sites
  3. Upgrade vue-eslint-parser to v10 to satisfy the peer dependency

"espree": "^10.4.0",
"lodash": "catalog:",
"requireindex": "^1.1.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/kolibri-format/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"eslint-plugin-jest-dom": "^5.5.0",
"eslint-plugin-kolibri": "workspace:*",
"eslint-plugin-small-import": "^1.0.0",
"eslint-plugin-vue": "^9.33.0",
"eslint-plugin-vue": "^10.8.0",
"fast-glob": "3.3.3",
"globals": "^16.0.0",
"kolibri-logging": "workspace:*",
Expand Down
43 changes: 26 additions & 17 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading