refactor(quest-engine): unify batch and single review payout logic - #107
Open
syed-ghufran-hassan wants to merge 9 commits into
Open
refactor(quest-engine): unify batch and single review payout logic#107syed-ghufran-hassan wants to merge 9 commits into
syed-ghufran-hassan wants to merge 9 commits into
Conversation
- Resolve conflicts by taking `main` version for all conflicted files. - Brings in boosted-multiplier mocks, comprehensive tests, and fixes duplicate definitions and setup errors. Closes learnault#91
Author
|
@Kaylahray is this all good to be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract common approval flow into internal helper to ensure batch and
single review submissions use identical payout logic.
This eliminates code duplication and ensures any future changes to
payout rules automatically apply to both review paths.
Depends on: [QuestEngine] Deliver uncapped staking multiplier payouts
Closes #88